fix(explore): let admin overwrite slice #16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16290 +/- ##
==========================================
- Coverage 76.70% 76.64% -0.07%
==========================================
Files 997 997
Lines 53240 53246 +6
Branches 6774 6777 +3
==========================================
- Hits 40838 40808 -30
- Misses 12172 12208 +36
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
approved these changes
Aug 17, 2021
|
🏷️ 2021.31 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 19, 2021
(cherry picked from commit d13b081)
rusackas
added a commit
that referenced
this pull request
Aug 24, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Aug 26, 2021
* upstream/master: (25 commits) chore(ci): bump pylint to 2.10.2 (apache#16463) fix: prevent page crash when chart can't render (apache#16464) chore: fixed slack invite link (apache#16466) fix(native-filters): handle null values in value filter (apache#16460) feat: add function list to auto-complete to Clickhouse datasource (apache#16234) refactor(explore): improve typing for Dnd controls (apache#16362) fix(explore): update overwrite button on perm change (apache#16437) feat: Draggable and Resizable Modal (apache#16394) refactor: sql_json view endpoint (apache#16441) fix(dashboard): undo and redo buttons weird alignment (apache#16417) fix: setupPlugin in chart list page (apache#16413) fix: Disable Slack notification method if no api token (apache#16367) feat: add Shillelagh DB engine spec (apache#16416) fix: copy to Clipboard order (apache#16299) docs: make FEATURE_FLAGS.md reference a link (apache#16415) chore(viz): bump superset-ui to 0.17.87 (apache#16420) feat: add activate command (apache#16404) Revert "fix(explore): let admin overwrite slice (apache#16290)" (apache#16408) fix(explore): retain chart ownership on query context update (apache#16419) chore: Removes the TODOs and uses the default page size (apache#16422) ...
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently Explore doesn't let Admins overwrite a slice if they don't belong to the owners group. This changes this so that admins have the
can_overwriteproperty on bootstrap data set toTrueif the user is an owner OR they are an Admin. In addition, the Edit Chart metadata modal is changed so that it is possible to save even if the owner list is empty. This is to align the behavior of the Chart metadata modal with the Dashboard metadata modal. See #15149 for more context on this change.AFTER
As an admin, the user can now overwrite the chart if they are an Admin:
In addition, the Chart metadata modal is now saveable even if the owners list is empty:
BEFORE
Currently the overwrite option is disabled for admins that aren't set as owners of a chart:
In addition, the Save button in the Chart metadata modal is disabled when empty:
ADDITIONAL INFORMATION